wasm: free clone callback after creation failure - #58
Merged
Merged
Conversation
The clone syscall allocates clone_fn before calling kernel_clone(), but only the child callback frees it. If creation fails, for example because CLONE_THREAD is set without CLONE_SIGHAND, no child runs the callback and the allocation leaks. Free clone_fn when kernel_clone() returns an error. On success, leave ownership with wasm_call_clone_fn(). Based on HighCWu/linux commit fa8637a ("wasm: free clone callback after creation failure").
tombl
marked this pull request as ready for review
October 4, 2026 14:08
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tombl
added a commit
to tombl/distro
that referenced
this pull request
Oct 4, 2026
Update the Linux pin to 5ad61429eac77535a904e70153ce1502bc82ff86, the commit merged into wasm from tombl/linux#58. The merged tree matches the previously tested PR head. Recomputed the unpacked source NAR hash from the merged commit archive; it is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applies the fix from HighCWu@fa8637a, fixing a leak that could occur if you repeatedly call clone with invalid flags.