ci: download Go modules in functional setup; F15/F16 inherit the module cache - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the functional job's Go module fetch out of the tests and into a fail-closed setup step.
Motivation: the first
mainrun after #1 (35921329256) failed in the functional job. The failure was 1 test out of 904: F16'sgo testsubprocess gotINTERNAL_ERRORfrom proxy.golang.org while downloadingk8s.io/kube-openapi. The re-run passed.functionalgains step 8, exactlygo mod download. It is unconditional and has no env. A proxy failure now fails setup before pytest starts.GOMODCACHE=/tmp/go-modfallbacks are removed.gogrammar admits exactlygo mod download.go mod downloadwithGOPROXY=offon an empty cache exits non-zero with a module-proxy refusal.The design, audit and code review are all approved.
🤖 Generated with Claude Code