test(ui): guard qrc resource keys against broken and stale references - #317
Merged
Merged
Conversation
This was referenced Sep 2, 2026
This was referenced Sep 2, 2026
gmmcosta15
force-pushed
the
test/resource-key-guard
branch
from
September 24, 2026 09:39
974fdd3 to
696f920
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Feature
Assert every
:/literal underlibis declared by a.qrc.Assert every
.qrc<file>exists on disk.Assert the
_rc.pyblobs match the.qrcXML and the current asset bytes.Assert every
.svgfont-familyresolves without substitution.XFAIL_KEYSrecords the keys already broken ondev; may only shrink.Motivation
Qt returns a null pixmap for a missing key and silently substitutes a missing font, logging neither. This makes both loud before the refactors land.
Tests
7 new tests, all passing.