Skip to content

fix(topbar): render filament icons in the bundled Momcake face - #320

Open
gmmcosta15 wants to merge 7 commits into
devfrom
fix/topbar-icon-fonts
Open

gmmcosta15 wants to merge 7 commits into
devfrom
fix/topbar-icon-fonts

Conversation

@gmmcosta15

Copy link
Copy Markdown
Collaborator

Description

  • Bug fix

  • Add lib/utils/fonts.py with a cached register_momcake().

  • Bundle the Momcake Thin and Bold faces in the qrc.

  • Correct the topbar .svg assets to name Momcake Pro, the family Qt files them under.

  • Call register_momcake() from updatePage before first paint.

Motivation

Nothing registered the family the topbar .svg files declare, so all of them rendered in the system fallback.

Tests

make check green; the PR 2 font test asserts no substitution.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI/UX User Interface what changed with this code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant