fix(ui): repair broken resource keys and give warning popups an icon - #318
Merged
Merged
Conversation
gmmcosta15
added
bug
This was referenced Sep 2, 2026
1 task
gmmcosta15
force-pushed
the
test/resource-key-guard
branch
from
September 24, 2026 09:39
974fdd3 to
696f920
Compare
…xes to split panels
gmmcosta15
removed this pull request from stack #330
September 28, 2026 12:46
gmmcosta15
added a commit
that referenced
this pull request
Sep 28, 2026
…rol fan icon to fan_related
gmmcosta15
added a commit
that referenced
this pull request
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fix
Repair broken
:/keys innetworkWindow,printTab,babystepPage,probeHelperPage,slider_selector_page.Repair the z-adjust back icon in
controlStackedWidget.Give the warning severity its own popup icon; clear it for unknown severity.
Harden the
BlocksLabelicon guard against a null pixmap.Delete dead pixmap references.
Motivation
Every key here painted blank on the panel. Empties
XFAIL_KEYS.Tests
make checkgreen;XFAIL_KEYSnow empty.Screenshots
Pending on-device check: warning and error popups share the octagon glyph, differing only by fill (
#E7E147vs#CA4949).