Skip to content

fix(doctor): detect disabled Claude hooks - #691

Open
vortsghost2025 wants to merge 1 commit into
DobermanCore:mainfrom
vortsghost2025:fix/doctor-disable-all-hooks-635
Open

fix(doctor): detect disabled Claude hooks#691
vortsghost2025 wants to merge 1 commit into
DobermanCore:mainfrom
vortsghost2025:fix/doctor-disable-all-hooks-635

Conversation

@vortsghost2025

Copy link
Copy Markdown
Contributor

Fixes #635

Summary

  • make doberman doctor report Hook integrity as a critical FAIL when an applicable Claude settings file has top-level JSON boolean disableAllHooks: true
  • keep the existing registration state (intact / diverged / absent) orthogonal by carrying the disabled condition separately
  • keep detection read-only; this never changes or clears disableAllHooks
  • preserve existing behavior when the key is absent or false, and only match the actual JSON boolean true (not "true" or 1)
  • malformed settings do not crash doctor

Validation

  • focused doctor/integrity validation passed locally
  • Ruff, formatting, import-linter, and git diff --check passed
  • repository-wide pytest was attempted but did not complete within the available timeout, so this PR does not claim a fully completed local full-suite run
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doctor: hooks turned off with disableAllHooks still report "intact"

1 participant