feat(val): nested validation dataset groups - #9
Open
AnikethCheluva wants to merge 1 commit into
Open
Conversation
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
AnikethCheluva
marked this pull request as ready for review
September 5, 2026 21:01
AnikethCheluva
force-pushed
the
graph-nested-val
branch
from
September 8, 2026 05:02
556420f to
d441759
Compare
AnikethCheluva
force-pushed
the
graph-transform_fixes
branch
from
September 8, 2026 05:02
987d938 to
556b987
Compare
This was referenced Sep 8, 2026
AnikethCheluva
changed the base branch from
graph-transform_fixes
to
graphite-base/9
September 8, 2026 23:32
AnikethCheluva
force-pushed
the
graphite-base/9
branch
from
September 9, 2026 22:21
556b987 to
16ddb58
Compare
AnikethCheluva
force-pushed
the
graph-nested-val
branch
from
September 9, 2026 22:21
d441759 to
3f84aac
Compare
AnikethCheluva
changed the base branch from
graphite-base/9
to
graph-transform_fixes
September 9, 2026 22:21
Port of GaTech-RL2#605 onto the graph fork. `valid_datasets` may now be `{group: {source: dataset}}` as well as the historical `{source: dataset}`. Lightning runs one val loop per group, in declaration order, so a run can validate against a held-out split and an unseen-task split in the same job without conflating their metrics. The two shapes are told apart by whether the top-level keys are embodiment names, not by value type -- hydra hands back instantiated objects for the flat shape and DictConfig for the grouped one, and that distinction is fragile across omegaconf versions. Note this lookup only disambiguates config shape; the pipeline runner still treats source keys as opaque and never resolves an embodiment from them. A single group returns the bare CombinedLoader, exactly as before, so existing configs keep their dataloader topology and `dataloader_idx` stays 0. Two or more return a list, which Lightning wraps in a sequential CombinedLoader of its own -- that wrapper passes the inner loader's `(batch, batch_idx, dataloader_idx)` triple through as the batch, so `_unwrap_combined_loader_batch` drops the redundant inner pair before PipelineAlgo sees it. `iter_valid_datasets()` is the way to reach all of validation. `valid_datasets` is kept as an alias for one group, and iterating it to wire norm stats is precisely the bug this guards: the skipped groups' datasets stay unnormalised, the evaluator unnormalises their samples anyway, and the metrics still look plausible. trainHydra now wires via the iterator and raises if any dataset is left unwired. Metrics namespace per group at one choke point: the default group keeps bare `Valid/...` names so existing runs overlay on the same charts, every other group logs `Valid_{group}/...`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DcPCNAW3GKERANrqvfSCY1
AnikethCheluva
force-pushed
the
graph-nested-val
branch
from
September 10, 2026 17:56
3f84aac to
59bb024
Compare
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Port of GaTech-RL2#605 onto the graph fork.
valid_datasetsmay now be{group: {source: dataset}}as well as thehistorical
{source: dataset}. Lightning runs one val loop per group, indeclaration order, so a run can validate against a held-out split and an
unseen-task split in the same job without conflating their metrics.
The two shapes are told apart by whether the top-level keys are embodiment
names, not by value type -- hydra hands back instantiated objects for the flat
shape and DictConfig for the grouped one, and that distinction is fragile
across omegaconf versions. Note this lookup only disambiguates config shape;
the pipeline runner still treats source keys as opaque and never resolves an
embodiment from them.
A single group returns the bare CombinedLoader, exactly as before, so existing
configs keep their dataloader topology and
dataloader_idxstays 0. Two ormore return a list, which Lightning wraps in a sequential CombinedLoader of its
own -- that wrapper passes the inner loader's
(batch, batch_idx, dataloader_idx)triple through as the batch, so_unwrap_combined_loader_batchdrops the redundant inner pair before PipelineAlgo sees it.
iter_valid_datasets()is the way to reach all of validation.valid_datasetsis kept as an alias for one group, and iterating it to wirenorm stats is precisely the bug this guards: the skipped groups' datasets stay
unnormalised, the evaluator unnormalises their samples anyway, and the metrics
still look plausible. trainHydra now wires via the iterator and raises if any
dataset is left unwired.
Metrics namespace per group at one choke point: the default group keeps bare
Valid/...names so existing runs overlay on the same charts, every othergroup logs
Valid_{group}/....Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01DcPCNAW3GKERANrqvfSCY1