Restore accuracy truncation bound in 2.1.2 - #77
Merged
Conversation
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FiniteTempBasis.accuracy: the relative first excluded singular valuemax_sizetruncation, and the no-excluded-value caseWhy
In 2.x,
accuracyreturned the last included singular value. That reversed the relationship expected by callers usingrequested_tolerance > basis.accuracy. The first excluded singular value is the truncation error bound and matches sparse-ir 1.x behavior.Verification
Release ordering
This PR accepts pylibsparseir 0.9.x, but Python 3.14 installation requires the CPython 3.14 wheel prepared in SpM-lab/sparse-ir-rs#251. Publish pylibsparseir 0.9.0 first, then sparse-ir 2.1.2.