Fix the fan-dipole build sheet cut list and geometry sketch - #10
Merged
Conversation
Two bugs, both from the build sheet reading the raw NEC deck — which for a fan
dipole splits every leg into two feed-gap halves fanned in azimuth plus a tiny
feed-bridge wire.
Cut list: the generic by-length grouping listed unlabelled half-wires ("Wire
1..4", quantity 2 each, at half the real length) plus a phantom 0.5 m bridge,
with no band shown — so a builder couldn't tell which wire was which band. Now
the fan dipole's cut list is built from the model's legs: one full-length wire
per band, labelled with its frequency (e.g. "Dipole leg for 14.175 MHz").
Sketch: the auto-projection drew the azimuth-fanned legs as an overlapping
star (mirrored left/right). Now the fan dipole gets a builder's schematic — the
legs drawn to scale as parallel dipoles, longest at the top, each labelled with
its band, tied together at a shared centre feedpoint.
Both fixes special-case FanDipoleModel in results/buildsheet.py and
results/sketch.py; every other antenna is untouched. Tests assert the cut list
has one labelled entry per leg (no phantom bridge) and the sketch draws one
labelled wire per leg. Suite 512 -> 514.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs (reported)
For a 40/20/15/10 m fan dipole:
Both stem from the build sheet/sketch reading the raw deck instead of the model.
Fix (both fan-dipole-specific; every other antenna untouched)
results/buildsheet.py) — built frommodel.legs: one full-length wire per band, labelled with its frequency (e.g. "Dipole leg for 14.175 MHz"), quantity 1, no phantom bridge.results/sketch.py) — a builder's schematic: the legs drawn to scale as parallel dipoles, longest at the top, each labelled with its band, tied together at a shared centre feedpoint.Before → after (cut list, 40/20/15/10)
Tests
tests/test_fan_dipole.py(+2): the cut list has one labelled, full-length entry per leg with no phantom bridge; the sketch draws one labelled wire per leg with the shared-feed schematic. Verified the build sheet still renders to Markdown and HTML (SVG embedded) for a fan dipole. Suite 512 → 514, green locally.🤖 Generated with Claude Code