Rollup of 20 pull requests - #163583
Merged
Merged
Rollup of 20 pull requests#163583
Conversation
Mark `rustfmt` as being managed by Josh
Adding tests addressing the changes in coretests/tests/num/clamp_magnitude.rs
Adding mod clamp_magnitude in coretests/num/mod.rs Activating feature(clamp_magnitude) in coretests/lib.rs Adding test coverage for f16, f128, and NaN as well as zero cases Modifying nonzero and int_macros documentation for better readablity
sanitizers.md: improve text
When a format string does not come directly from a string literal in the source, e.g. when it is produced by `concat!`, the parser's inner offsets are relative to the expanded string rather than to the source. The primary error span and the `RemoveRawIdent` suggestion already check `is_source_literal` before calling `fmt_span.from_inner`, but the `UsePositional`, `ReorderFormatParameter` and `AddMissingColon` suggestions did not. As a result, these suggestions could point into the middle of a multibyte character and ICE when rendered, or suggest a bogus argument copied from unrelated source text. Only emit them when the format string is a source literal, like the other suggestions do. The crash test is moved to `tests/ui/fmt`, with cases covering each of these suggestions.
…const-generics Update ConstKind::Alias in const generics docs
Update debuginfo testing information w/ GDB changes
Prior to rust-lang#159633, the compiler made an invalid suggestion: ``` help: must be of the form | 1 - #[cfg_attr(true, cfg_attr(true, 3))] 1 + #[cfg_attr(true, #[cfg_attr(predicate, attr1, attr2, ...)])] ``` Now it is correct: ``` help: must be of the form | 1 - #[cfg_attr(true, cfg_attr(true, 3))] 1 + #[cfg_attr(true, cfg_attr(predicate, attr1, attr2, ...))] ``` But there was no test for it. This commit adds one.
This commit adds a new test for some uncovered cases. The thing to note here is the varying correctness of the `help:` lines. This is correct: ``` LL | #[inline] | ^^^^^^^^^ help: remove this attribute ``` The following two are half correct. They give the right idea but if applied literally they will produce syntax that triggers either a warning (the former) or an error (the latter). ``` LL | #[cfg_attr(true, inline)] | ^^^^^^ help: remove this attribute LL | #[cfg_attr(true, inline, deprecated)] | ^^^^^^ help: remove this attribute ``` For this reason, this commit also marks these help messages as not machine-applicable. This means we lose the machine applicability on some cases where it's correct, but it seems better to be conservative.
…e guide review changes
Construction of such types should never be so implicit.
Currently it covers "int-like" types: integers, integer inference variables, bools, chars, and C-like enums. It's a bit weird, especially the asymmetry between the fielded `U` and fieldless `I` variants. This commit merges it into `CastTy`, and adds an `is_int_like` method. Some of the checking is now more strict, accepting only ints where before it accepted int-likes (e.g. casting a bool to a ptr) in `TypeChecker::visit_rvalue` and `mir_cast_kind`. `CastCheck::do_check` already rejects these int-like cases, which means they can't occur in MIR built from THIR. The only way to hit the stricter checking is in custom MIR. The commit also removes some unused derives from `CastKind` and fixes a couple of stale comments.
rust-bors
Bot
removed
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 1, 2026
Rollup of 20 pull requests try-job: test-aarch64-msvc-1
Member
|
Trying commonly failed jobs |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 1, 2026
Rollup of 20 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-gnu-llvm-21-3 try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu
This comment has been minimized.
This comment has been minimized.
Contributor
rust-bors
Bot
added
merged-by-bors
Contributor
This was referenced Oct 1, 2026
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 012c0bd (parent) -> 837b18a (this PR) Test differencesShow 698 test diffsStage 1
Stage 2
Additionally, 626 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 837b18aae097503892d7aab6c7ddce332a991a21 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: 012c0bd4d5 In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (837b18a): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.8%, secondary -0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.2%, secondary -2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 490.746s -> 490.365s (-0.08%) |
Member
|
@rust-timer triage `e6fe38b5a1980063ac0dbda1a48affeac47d958 |
Collaborator
|
Sha ``e6fe38b5a1980063ac0dbda1a48affeac47d958` is not alphanumeric |
Member
|
@rust-timer triage e6fe38b5a1980063ac0dbda1a48affeac47d958 |
Collaborator
Running triage with 46 benchmarksTriage only executes the benchmarks on rollup members, that were changed significantly on the rollup.
e6fe38b5a1980063ac0dbda1a48affeac47d958Failed to get commit: 422 != 200 OK |
Member
|
@rust-timer triage 3e6fe38 |
Collaborator
Running triage with 46 benchmarksTriage only executes the benchmarks on rollup members, that were changed significantly on the rollup.
#163455 3e6fe38 Don't use the metadata based crate_hash for rustdoc runsInstruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesResults (primary -2.6%, secondary -3.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ComplexGCC-compatible #162921 (make mips64ComplexGCC-compatible)concat!offsets #163368 (Don't build format string suggestions fromconcat!offsets)expectguidance #163375 (Update expect messages in library/std/src/os/unix/net/ following Rust'sexpectguidance)Resolver#163509 (Use more default field values inResolver)Reborrowimpls for types with destructors #163519 (ForbidReborrowimpls for types with destructors)Resultcase for thearena_cachequery modifier #163524 (DocumentResultcase for thearena_cachequery modifier)#[unsafe(no_mangle)]for entry points inno_stdbinaries #163559 (Suggest#[unsafe(no_mangle)]for entry points inno_stdbinaries)r? @ghost
Create a similar rollup